Skip to content

Commit

Permalink
Fix parquet reader list bug (#17699)
Browse files Browse the repository at this point in the history
This fixes a bug in the parquet list reader, where if a row had a list so long that it spanned a whole page, we would skip reading the page entirely.

Authors:
  - Paul Mattione (https://github.com/pmattione-nvidia)

Approvers:
  - https://github.com/nvdbaranec
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #17699
  • Loading branch information
pmattione-nvidia authored Jan 9, 2025
1 parent bf80433 commit f13d8fc
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions cpp/src/io/parquet/decode_fixed.cu
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2024, NVIDIA CORPORATION.
* Copyright (c) 2024-2025, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -961,9 +961,6 @@ CUDF_KERNEL void __launch_bounds__(decode_block_size_t, 8)
return;
}

// if we have no work to do (eg, in a skip_rows/num_rows case) in this page.
if (s->num_rows == 0) { return; }

using value_decoder_type = std::conditional_t<
split_decode_t,
decode_fixed_width_split_values_func<decode_block_size_t, has_lists_t, state_buf_t>,
Expand Down

0 comments on commit f13d8fc

Please sign in to comment.