Skip to content

Commit

Permalink
Remove deprecated public APIs from libcudf (#16524)
Browse files Browse the repository at this point in the history
Removing some more deprecated public libcudf APIs.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Karthikeyan (https://github.com/karthikeyann)

URL: #16524
  • Loading branch information
davidwendt authored Aug 12, 2024
1 parent a3dc14f commit 091cb72
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 47 deletions.
12 changes: 0 additions & 12 deletions cpp/include/cudf/strings/replace.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -160,18 +160,6 @@ std::unique_ptr<column> replace_multiple(
rmm::cuda_stream_view stream = cudf::get_default_stream(),
rmm::device_async_resource_ref mr = rmm::mr::get_current_device_resource());

/**
* @copydoc cudf::strings::replace_multiple
*
* @deprecated since 24.08
*/
[[deprecated]] std::unique_ptr<column> replace(
strings_column_view const& input,
strings_column_view const& targets,
strings_column_view const& repls,
rmm::cuda_stream_view stream = cudf::get_default_stream(),
rmm::device_async_resource_ref mr = rmm::mr::get_current_device_resource());

/** @} */ // end of doxygen group
} // namespace strings
} // namespace CUDF_EXPORT cudf
19 changes: 0 additions & 19 deletions cpp/include/cudf/utilities/type_checks.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,6 @@

namespace CUDF_EXPORT cudf {

/**
* @brief Compare the types of two `column_view`s
*
* @deprecated Since 24.06. Use cudf::have_same_types instead.
*
* This function returns true if the type of `lhs` equals that of `rhs`.
* - For fixed point types, the scale is compared.
* - For dictionary types, the type of the keys are compared if both are
* non-empty columns.
* - For lists types, the type of child columns are compared recursively.
* - For struct types, the type of each field are compared in order.
* - For all other types, the `id` of `data_type` is compared.
*
* @param lhs The first `column_view` to compare
* @param rhs The second `column_view` to compare
* @return true if column types match
*/
[[deprecated]] bool column_types_equal(column_view const& lhs, column_view const& rhs);

/**
* @brief Compare the type IDs of two `column_view`s
*
Expand Down
11 changes: 0 additions & 11 deletions cpp/src/strings/replace/multi.cu
Original file line number Diff line number Diff line change
Expand Up @@ -533,16 +533,5 @@ std::unique_ptr<column> replace_multiple(strings_column_view const& strings,
return detail::replace_multiple(strings, targets, repls, stream, mr);
}

// deprecated in 24.08
std::unique_ptr<column> replace(strings_column_view const& strings,
strings_column_view const& targets,
strings_column_view const& repls,
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr)
{
CUDF_FUNC_RANGE();
return detail::replace_multiple(strings, targets, repls, stream, mr);
}

} // namespace strings
} // namespace cudf
5 changes: 0 additions & 5 deletions cpp/src/utilities/type_checks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,6 @@ bool have_same_types(column_view const& lhs, column_view const& rhs)
return type_dispatcher(lhs.type(), columns_equal_fn{}, lhs, rhs);
}

bool column_types_equal(column_view const& lhs, column_view const& rhs)
{
return have_same_types(lhs, rhs);
}

bool have_same_types(column_view const& lhs, scalar const& rhs)
{
return type_dispatcher(lhs.type(), column_scalar_equal_fn{}, lhs, rhs);
Expand Down

0 comments on commit 091cb72

Please sign in to comment.