Retry update with latest secret if plan still matches the applied plan #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Kim <[email protected]>
Oats87
requested review from
jakefhyde,
HarrisonWAffel and
aiyengar2
as code owners
|
Tested through the integration framework for etcd restore on the etcd node: |
jakefhyde
approved these changes
May 4, 2023
HarrisonWAffel
approved these changes
May 4, 2023
| } | ||
| // If we get a conflict, we can retrieve the latest secret and compare plan data to see if the plan changed. | ||
| latestSecret, getErr := core.Secret().Get(secret.Namespace, secret.Name, metav1.GetOptions{}) | ||
| if getErr == nil { |
There was a problem hiding this comment.
we could avoid nesting if we invert the condition, but this is more of a nit as the current nesting doesn't significantly impact readability
There was a problem hiding this comment.
yeah... this was a little hasty in an attempt to fix this, I can come back and fix this later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#113