[v0.10] - Always returns result with RequeueAfter set #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xavi0
force-pushed
the
0.10-3138-requeue-after
branch
2 times, most recently
from
fafe3ed to
78a32cb
Compare
0xavi0
force-pushed
the
0.10-3138-requeue-after
branch
from
78a32cb to
3cce032
Compare
weyfonk
approved these changes
Jan 23, 2025
Changes the gitops reconciler result to always have the polling interval in RequeueAfter. This way we take advantage of the fact that if there is already an event in the RequeueAfter queue the next ones will be dropped and we won't miss the polling cycle if there is a race condition between RequeueAfter events and any other event in the reconciler. This is only added when `DisablePolling` is not set. Signed-off-by: Xavi Garcia <[email protected]>
0xavi0
force-pushed
the
0.10-3138-requeue-after
branch
from
3cce032 to
8c9800e
Compare
aruiz14
reviewed
Jan 23, 2025
0xavi0
force-pushed
the
0.10-3138-requeue-after
branch
from
f30a8a3 to
afbeac4
Compare
aruiz14
reviewed
Jan 23, 2025
Signed-off-by: Xavi Garcia <[email protected]>
0xavi0
force-pushed
the
0.10-3138-requeue-after
branch
from
afbeac4 to
32e7cf5
Compare
aruiz14
approved these changes
Jan 23, 2025
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Jan 24, 2025
Ports rancher#3239 to v0.11 Signed-off-by: Xavi Garcia <[email protected]>
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Jan 27, 2025
Port of: rancher#3239 Refers to rancher#3252 Signed-off-by: Xavi Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the gitops reconciler result to always have the polling interval in RequeueAfter. This way we take advantage of the fact that if there is already an event in the RequeueAfter queue the next ones will be dropped and we won't miss the polling cycle if there is a race condition between RequeueAfter events and any other event in the reconciler.
This is only added when
DisablePollingis not set.Refers to #3138
Refers to #3250