Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding handlebar support for yaml structs #1136

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Adding handlebar support for yaml structs #1136

merged 10 commits into from
Jan 13, 2025

Conversation

findolor
Copy link
Collaborator

@findolor findolor commented Jan 10, 2025 •
edited
Loading

Motivation

See issue: #1100 and #1135

Solution

  • Add context logic based on New context struct #1122
  • Implement order trait in context for future upgradeability
  • Update tests

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@findolor findolor requested a review from hardyjosh January 10, 2025 19:40
@findolor findolor self-assigned this Jan 10, 2025
@findolor findolor linked an issue Jan 10, 2025 that may be closed by this pull request
Handlebars replacement for contextual information #1100
Closed
@hardyjosh hardyjosh enabled auto-merge January 13, 2025 16:14
@hardyjosh hardyjosh merged commit 2a65df5 into main Jan 13, 2025
21 checks passed
@hardyjosh hardyjosh mentioned this pull request Jan 15, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh approved these changes

Assignees

@findolor findolor

Labels
webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handlebars replacement for contextual information
2 participants
@findolor @hardyjosh