Get vault balances for orderlist in cli #1011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavidmeister
requested changes
Dec 12, 2024
| // Build the GraphQL query with the provided variables. | ||
| let query = OrdersListQuery::build(variables); | ||
|
|
||
| let req = client |
There was a problem hiding this comment.
it seems weird to me that this request is being handled like this inline
aren't other queries also doing basically the same thing? wouldn't it make more sense to have a standard way to fetch the query data from the subgraph and have all queries use it?
There was a problem hiding this comment.
Yes we have this already- @ninokeldishvili can you use it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Get vault balances for orderlist in cli
Solution
Add functionality to get data for orders to get balances under orders
Checks
By submitting this for review, I'm confirming I've done the following:
Depends on #996