Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert auth templates for Rails 8 beta1 #409

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Oct 1, 2024

Do not merge until Rails 8 beta2 is released.

Reverts part of #408 which fixed #407's backwards-incompatible change.

@flavorjones flavorjones force-pushed the flavorjones-rails8beta1-auth-templates-revert branch 3 times, most recently from 7c46d2e to d209685 Compare October 1, 2024 23:21
@flavorjones
Copy link
Member Author

The failure on upstream / user-journey (rails v8.0.0.beta1) is expected; once beta2 is out I'll bump the matrix and this should go green.

@flavorjones flavorjones force-pushed the flavorjones-rails8beta1-auth-templates-revert branch 3 times, most recently from ce18144 to d6fa987 Compare October 2, 2024 14:42
@flavorjones flavorjones force-pushed the flavorjones-rails8beta1-auth-templates-revert branch from d6fa987 to cfa33d9 Compare November 15, 2024 15:35
@flavorjones
Copy link
Member Author

Bumped the matrix.

@flavorjones flavorjones merged commit 171975a into main Nov 15, 2024
17 checks passed
@flavorjones flavorjones deleted the flavorjones-rails8beta1-auth-templates-revert branch November 15, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant