Handle syntax error in property correctly.

The relevant exception handler would return (void) instead of a boolean, breaking the relevant contract.
racket · Nov 1, 2024 · 33a7a63 · 33a7a63
1 parent b80dc8d
commit 33a7a63
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/htdp-lib/lang/private/teach.rkt b/htdp-lib/lang/private/teach.rkt
@@ -3310,7 +3310,8 @@
   (with-handlers ((exn:fail?
                    (lambda (e)
                      (add-failed-check! (failed-check (property-error srcloc e)
-                                                      (exn-srcloc e))))))
+                                                      (exn-srcloc e)))
+                     #f)))
     (call-with-values
      (lambda ()
        (with-handlers

diff --git a/htdp-test/tests/test-engine/racket-tests.rkt b/htdp-test/tests/test-engine/racket-tests.rkt
@@ -268,6 +268,7 @@
    (= (/ a b) (/ b a))))
 (check-failure property-fail?)
 
-
-
-
+; check for malformed property
+(check-property
+ (for-all ((minutes)) #t))
+(check-failure property-error?)