feat: [AXIMST-605] add file name to upload preview modal #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladislavkeblysh
requested review from
ihor-romaniuk,
ruzniaievdm,
monteri,
khudym and
PKulkoRaccoonGang
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ts-develop #202 +/- ##
=============================================
Coverage ? 89.50%
=============================================
Files ? 651
Lines ? 10884
Branches ? 2253
=============================================
Hits ? 9742
Misses ? 1103
Partials ? 39 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| .modal-preview-text { | ||
| font-size: 14px; |
There was a problem hiding this comment.
[nit] It's better to use flexible units of measurement
Suggested change
| font-size: 14px; | |
| font-size: .875rem; |
|
@vladislavkeblysh Please increase your test coverage according to the |
monteri
approved these changes
Mar 11, 2024
khudym
pushed a commit
that referenced
this pull request
Mar 25, 2024
monteri
pushed a commit
that referenced
this pull request
Apr 1, 2024
monteri
pushed a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXIMST-605