Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [AXIMST-544] Unit page - display component support label #194

Merged

Conversation

ihor-romaniuk
Copy link
Collaborator

Description: Unit page - display component support label

Youtrack: https://youtrack.raccoongang.com/issue/AXIMST-544

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/AXIMST-544/display-component-support-label branch from ec143d4 to dd96c5e Compare February 29, 2024 09:28
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (ts-develop@fecc709). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             ts-develop     #194   +/-   ##
=============================================
  Coverage              ?   89.53%           
=============================================
  Files                 ?      651           
  Lines                 ?    10884           
  Branches              ?     2256           
=============================================
  Hits                  ?     9745           
  Misses                ?     1100           
  Partials              ?       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/AXIMST-544/display-component-support-label branch from dd96c5e to c680836 Compare February 29, 2024 10:15
@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/AXIMST-544/display-component-support-label branch from c680836 to 210f2d7 Compare March 7, 2024 16:48
@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/AXIMST-544/display-component-support-label branch from 9072fae to 6163c11 Compare March 11, 2024 09:39
@ihor-romaniuk ihor-romaniuk marked this pull request as ready for review March 11, 2024 09:39
boilerplate: 'peer-assessment',
});
});

describe('component support label', () => {
it('doesn\'t display component support label if component support legend is disabled', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's advisable to avoid using reverse logic words like 'doesn't display.' It can make the test steps less intuitive to understand. Instead, opting for more affirmative language such as 'is hidden' would enhance clarity.

Let's consider component support label is hidden if component support legend is disabled

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for other cases the same idea

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@@ -84,3 +86,18 @@ export const PUBLISH_TYPES = {
discardChanges: 'discard_changes',
makePublic: 'make_public',
};

export const getXBlockSupportMessages = (intl) => ({
fs: { // Fully supported
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] is it not better to provide full key name instead of abbreviation? Like fullySupported to make it more clear and avoid comment then.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keys we receive from the API and here we just map them

@monteri monteri merged commit 8048f9b into ts-develop Mar 12, 2024
3 checks passed
@ihor-romaniuk ihor-romaniuk deleted the romaniuk/AXIMST-544/display-component-support-label branch March 12, 2024 11:42
khudym pushed a commit that referenced this pull request Mar 25, 2024
* feat: [AXIMST-544] Unit page - display component support label

* refactor: constant name and replace hardcoded string with constant

* fix: after review
monteri pushed a commit that referenced this pull request Apr 1, 2024
* feat: [AXIMST-544] Unit page - display component support label

* refactor: constant name and replace hardcoded string with constant

* fix: after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants