-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [AXIMST-544] Unit page - display component support label #194
feat: [AXIMST-544] Unit page - display component support label #194
Conversation
ec143d4
to
dd96c5e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ts-develop #194 +/- ##
=============================================
Coverage ? 89.53%
=============================================
Files ? 651
Lines ? 10884
Branches ? 2256
=============================================
Hits ? 9745
Misses ? 1100
Partials ? 39 ☔ View full report in Codecov by Sentry. |
dd96c5e
to
c680836
Compare
f0efff1
to
1d1c07d
Compare
c680836
to
210f2d7
Compare
9072fae
to
6163c11
Compare
boilerplate: 'peer-assessment', | ||
}); | ||
}); | ||
|
||
describe('component support label', () => { | ||
it('doesn\'t display component support label if component support legend is disabled', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's advisable to avoid using reverse logic words like 'doesn't display.' It can make the test steps less intuitive to understand. Instead, opting for more affirmative language such as 'is hidden' would enhance clarity.
Let's consider component support label is hidden if component support legend is disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And for other cases the same idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
@@ -84,3 +86,18 @@ export const PUBLISH_TYPES = { | |||
discardChanges: 'discard_changes', | |||
makePublic: 'make_public', | |||
}; | |||
|
|||
export const getXBlockSupportMessages = (intl) => ({ | |||
fs: { // Fully supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question] is it not better to provide full key name instead of abbreviation? Like fullySupported
to make it more clear and avoid comment then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This keys we receive from the API and here we just map them
* feat: [AXIMST-544] Unit page - display component support label * refactor: constant name and replace hardcoded string with constant * fix: after review
* feat: [AXIMST-544] Unit page - display component support label * refactor: constant name and replace hardcoded string with constant * fix: after review
Description: Unit page - display component support label
Youtrack: https://youtrack.raccoongang.com/issue/AXIMST-544