fix: [AXIMST-510] there is no message if a user upload a large file #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monteri
requested review from
GlugovGrGlib,
ruzniaievdm,
khudym and
PKulkoRaccoonGang
monteri
commented
Feb 22, 2024
| @@ -57,4 +57,4 @@ export const COURSE_BLOCK_NAMES = /** @type {const} */ ({ | |||
| component: { id: 'component', name: 'Component' }, | |||
| }); | |||
|
|
|||
| export const UPLOAD_FILE_MAX_SIZE = 100 * 1024 * 1024; // 100mb | |||
| export const UPLOAD_FILE_MAX_SIZE = 20 * 1000 * 1000; // 20mb | |||
There was a problem hiding this comment.
When I have a file with such size as shown on the picture it will 20312736.
In that time if I set 20 * 1024 * 1024 it results in 20971520. This means that 20312736 is valid size. But when I upload to the server I receive 413 error that means the file is too large.
The solution is to set 20 * 1000 * 1000 that works good for both backend and frontend.
ruzniaievdm
requested changes
Feb 22, 2024
monteri
force-pushed
the
zadorozhnii/max-file-size-issue
branch
from
be93e22 to
f8ec3b0
Compare
monteri
force-pushed
the
zadorozhnii/max-file-size-issue
branch
from
f8ec3b0 to
deca896
Compare
khudym
reviewed
Feb 23, 2024
| } finally { | ||
| setDisabledUploadBtn(true); | ||
| setUploadProgress(0); | ||
| setPreviewUrl(null); | ||
| } |
There was a problem hiding this comment.
ill take this approach with finally into account:)
khudym
approved these changes
Feb 23, 2024
ruzniaievdm
reviewed
Feb 23, 2024
| @@ -43,6 +44,11 @@ const ModalDropzone = ({ | |||
| onChange, onCancel, onClose, fileTypes, onSavingStatus, | |||
| }); | |||
|
|
|||
| const invalidSizeMore = intl.formatMessage( | |||
There was a problem hiding this comment.
[nit]
Suggested change
| const invalidSizeMore = intl.formatMessage( | |
| const invalidSizeMoreMsg = intl.formatMessage( |
ruzniaievdm
approved these changes
Feb 23, 2024
ihor-romaniuk
pushed a commit
that referenced
this pull request
Feb 29, 2024
…183) * fix: [AXIMST-510] there is no message if a user upload a large file * fix: after review * fix: add translations --------- Co-authored-by: monteri <lansevermore>
ihor-romaniuk
pushed a commit
that referenced
this pull request
Feb 29, 2024
…183) * fix: [AXIMST-510] there is no message if a user upload a large file * fix: after review * fix: add translations --------- Co-authored-by: monteri <lansevermore>
khudym
pushed a commit
that referenced
this pull request
Mar 25, 2024
…183) * fix: [AXIMST-510] there is no message if a user upload a large file * fix: after review * fix: add translations --------- Co-authored-by: monteri <lansevermore>
monteri
added a commit
that referenced
this pull request
Apr 1, 2024
…183) * fix: [AXIMST-510] there is no message if a user upload a large file * fix: after review * fix: add translations --------- Co-authored-by: monteri <lansevermore>
monteri
pushed a commit
that referenced
this pull request
Apr 29, 2024
…183) * fix: [AXIMST-510] there is no message if a user upload a large file * fix: after review * fix: add translations --------- Co-authored-by: monteri <lansevermore>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.raccoongang.com/issue/AXIMST-489/uploadlimit-there-is-no-message-if-a-user-upload-a-large-file