fix: [AXIMST-488-489] Textbooks: file size and upload connection alert #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladislavkeblysh
requested review from
ihor-romaniuk,
ruzniaievdm,
monteri,
khudym and
PKulkoRaccoonGang
khudym
approved these changes
Feb 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ts-develop #174 +/- ##
=============================================
Coverage ? 89.22%
=============================================
Files ? 671
Lines ? 11265
Branches ? 2378
=============================================
Hits ? 10051
Misses ? 1175
Partials ? 39 ☔ View full report in Codecov by Sentry. |
vladislavkeblysh
changed the title
PKulkoRaccoonGang
requested changes
Feb 19, 2024
src/textbooks/Textbooks.scss
Outdated
| @import "./empty-placeholder/EmptyPlaceholder"; | ||
| @import "./textbook-card/TextbookCard"; | ||
| @import "./textbook-form/TextbookForm"; | ||
|
|
||
| .alert-toast { | ||
| z-index: $popover !important; |
There was a problem hiding this comment.
[important]: Try to use Paragon SCSS variable
Suggested change
| z-index: $popover !important; | |
| z-index: $zindex-tooltip !important; |
There was a problem hiding this comment.
@PKulkoRaccoonGang We have the same variable for certificates page, should we change there also?
There was a problem hiding this comment.
i remember that you suggested exactly this naming so im curious
Comment on lines
23
to
26
| import { useModel } from '../../generic/model-store'; | ||
| import textbookFormValidationSchema from './validations'; | ||
| import messages from './messages'; | ||
| import { UPLOAD_FILE_MAX_SIZE } from '../../constants'; |
There was a problem hiding this comment.
Suggested change
| import { useModel } from '../../generic/model-store'; | |
| import textbookFormValidationSchema from './validations'; | |
| import messages from './messages'; | |
| import { UPLOAD_FILE_MAX_SIZE } from '../../constants'; | |
| import { useModel } from '../../generic/model-store'; | |
| import { UPLOAD_FILE_MAX_SIZE } from '../../constants'; | |
| import textbookFormValidationSchema from './validations'; | |
| import messages from './messages'; |
monteri
approved these changes
Feb 19, 2024
monteri
approved these changes
Feb 20, 2024
ihor-romaniuk
pushed a commit
that referenced
this pull request
Feb 29, 2024
#174) * fix: [AXIMST-488-489] file size and upload connection alert * fix: [AXIMST-488-489] refactor after review
ihor-romaniuk
pushed a commit
that referenced
this pull request
Feb 29, 2024
#174) * fix: [AXIMST-488-489] file size and upload connection alert * fix: [AXIMST-488-489] refactor after review
khudym
pushed a commit
that referenced
this pull request
Mar 25, 2024
#174) * fix: [AXIMST-488-489] file size and upload connection alert * fix: [AXIMST-488-489] refactor after review
monteri
pushed a commit
that referenced
this pull request
Apr 1, 2024
#174) * fix: [AXIMST-488-489] file size and upload connection alert * fix: [AXIMST-488-489] refactor after review
monteri
pushed a commit
that referenced
this pull request
Apr 29, 2024
#174) * fix: [AXIMST-488-489] file size and upload connection alert * fix: [AXIMST-488-489] refactor after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXIMST-488
AXIMST-489