Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [AXIMST-129] Textbooks: Textbook preview #172

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

vladislavkeblysh
Copy link

@vladislavkeblysh vladislavkeblysh commented Feb 17, 2024

  • Add textbook preview

AXIMST-129

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (ts-develop@0ea5dd3). Click here to learn what that means.

Files Patch % Lines
src/textbooks/textbook-card/TextbooksCard.jsx 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             ts-develop     #172   +/-   ##
=============================================
  Coverage              ?   89.22%           
=============================================
  Files                 ?      671           
  Lines                 ?    11264           
  Branches              ?     2378           
=============================================
  Hits                  ?    10050           
  Misses                ?     1175           
  Partials              ?       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review February 19, 2024 10:55
@@ -68,7 +75,7 @@ const TextbookCard = ({
src={ViewIcon}
iconAs={Icon}
data-testid="textbook-view-button"
onClick={() => null}
onClick={() => onPreviewTextbookClick()}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onClick={() => onPreviewTextbookClick()}
onClick={onPreviewTextbookClick}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@monteri monteri merged commit dc2c1d0 into ts-develop Feb 20, 2024
3 checks passed
ihor-romaniuk pushed a commit that referenced this pull request Feb 29, 2024
* feat: [AXIMST-129] add textbook preview

* feat: [AXIMST-129] refactor after review
ihor-romaniuk pushed a commit that referenced this pull request Feb 29, 2024
* feat: [AXIMST-129] add textbook preview

* feat: [AXIMST-129] refactor after review
khudym pushed a commit that referenced this pull request Mar 25, 2024
* feat: [AXIMST-129] add textbook preview

* feat: [AXIMST-129] refactor after review
monteri pushed a commit that referenced this pull request Apr 1, 2024
* feat: [AXIMST-129] add textbook preview

* feat: [AXIMST-129] refactor after review
monteri pushed a commit that referenced this pull request Apr 29, 2024
* feat: [AXIMST-129] add textbook preview

* feat: [AXIMST-129] refactor after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants