fix: [ACI-987] fix penalties not revoking

credentials/apps/badges/models.py

@@ -228,7 +228,7 @@ def reset(self, username: str):
             requirement=self,
             progress__username=username,
         ).first()
-        deleted, __ = fulfillment.delete()
+        deleted, __ = fulfillment.delete() if fulfillment else (False, 0)
         if deleted:
             notify_requirement_regressed(
                 sender=self,

credentials/apps/badges/signals/signals.py

@@ -37,9 +37,15 @@ def notify_requirement_fulfilled(*, sender, username, badge_template_id, **kwarg
 
 def notify_requirement_regressed(*, sender, username, badge_template_id):
     """
-    FIXME: implement/use
+    Notifies about user's regression on the badge template.
     """
 
+    BADGE_REQUIREMENT_REGRESSED.send(
+        sender=sender,
+        username=username,
+        badge_template_id=badge_template_id,
+    )
+
 
 def notify_progress_complete(sender, username, badge_template_id):
     """
@@ -55,7 +61,7 @@ def notify_progress_complete(sender, username, badge_template_id):
 
 def notify_progress_incomplete(sender, username, badge_template_id):
     """
-    FIXME: implement/use
+    Notifies about user's regression on the badge template.
     """
     BADGE_PROGRESS_INCOMPLETE.send(
         sender=sender,

credentials/apps/badges/tests/test_signals.py

@@ -10,7 +10,7 @@
     CredlyOrganization,
 )
 from credentials.apps.badges.issuers import CredlyBadgeTemplateIssuer
-from credentials.apps.badges.signals.signals import BADGE_PROGRESS_COMPLETE
+from credentials.apps.badges.signals.signals import BADGE_PROGRESS_COMPLETE, BADGE_PROGRESS_INCOMPLETE
 
 
 class BadgeSignalReceiverTestCase(TestCase):
@@ -24,7 +24,7 @@ def setUp(self):
             name="test", site_id=1, organization=credly_organization
         )
 
-    def test_signal_emission_and_receiver_execution(self):
+    def test_progression_signal_emission_and_receiver_execution(self):
         # Emit the signal
         with mock.patch("credentials.apps.badges.issuers.notify_badge_awarded"):
             with mock.patch.object(CredlyBadgeTemplateIssuer, "issue_credly_badge"):
@@ -37,7 +37,9 @@ def test_signal_emission_and_receiver_execution(self):
         # UserCredential object
         user_credential = CredlyBadge.objects.filter(
             username="test_user",
-            credential_content_type=ContentType.objects.get_for_model(self.badge_template),
+            credential_content_type=ContentType.objects.get_for_model(
+                self.badge_template
+            ),
             credential_id=self.badge_template.id,
         )
 
@@ -46,3 +48,28 @@ def test_signal_emission_and_receiver_execution(self):
 
         # Check if user credential status is 'awarded'
         self.assertTrue(user_credential[0].status == "awarded")
+
+    def test_regression_signal_emission_and_receiver_execution(self):
+        # Emit the signal
+        with mock.patch("credentials.apps.badges.issuers.notify_badge_revoked"):
+            with mock.patch.object(CredlyBadgeTemplateIssuer, "revoke_credly_badge"):
+                BADGE_PROGRESS_INCOMPLETE.send(
+                    sender=self,
+                    username="test_user",
+                    badge_template_id=self.badge_template.id,
+                )
+
+        # UserCredential object
+        user_credential = CredlyBadge.objects.filter(
+            username="test_user",
+            credential_content_type=ContentType.objects.get_for_model(
+                self.badge_template
+            ),
+            credential_id=self.badge_template.id,
+        )
+
+        # Check if user credential is created
+        self.assertTrue(user_credential.exists())
+
+        # Check if user credential status is 'revoked'
+        self.assertTrue(user_credential[0].status == "revoked")