Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/220 overwatch functions #234

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Feat/220 overwatch functions #234

wants to merge 36 commits into from

Conversation

portalBlock
Copy link
Member

Initial Checklist

  • Has @tigattack / @issy been added as a reviewer?
  • If applicable, have the relevant project(s), milestone(s), and label(s) been applied?
  • If applicable, have you added details of the cog to the readme as per README.md?

Details

Does this resolve an issue?
Resolves #220

Changes

Features / Fixes

  • Adds embed/attachment frequency monitoring
  • Adds profile name monitoring
  • Adds voice channel monitoring

Breaking Changes

  • Should be none.

Additional

All have been tested and are working. The config defaults are crazy and will need to be tuned to established numbers following installation.

portalBlock added 30 commits May 7, 2023 14:24
@portalBlock
Add Overwatch profile rules cog.
44e8340
@portalBlock
Add the log channel command to set the output channel (oops, missed t…
4678785 
…hat). Also fix some message formatting.
@portalBlock
Use the correct config access when loading rules.
a5ab5a5
@portalBlock
Correct a breaking typo.
a6e0b00
@portalBlock
Correct a missed config access error.
0574223
@portalBlock
Change matchers to rules for more clarity, remove some default config…
7d3ec2a 
…s that appear to be causing an issue.
@portalBlock
Missed the adding logic while renaming before.
586983c
@portalBlock
Add back the default config? I'm not even sure what's going on with t…
5cce5b4 
…his now. It's more broken than when I started.
@portalBlock
Fill out the default config more as a sample. Restore (and hopefully …
1fe7a57 
…fix) nickname checking. Adjust rule parameter order to allow full collection of the reason.
@portalBlock
Add rule list command.
29220d2
@portalBlock
For a thing
f9ace2a
@portalBlock
Fix a typo...
c76a81e
@portalBlock
Rename ow_profile to owprofile and create owvoice cog base.
44a8621
@portalBlock
Implement Overwatch voice capabilities.
66f5245
@portalBlock
Attempt to fix a perfectly sensible error.
b3e08e4
@portalBlock
IDE auto import at it again.
1560083
@portalBlock
Oh wait, I forgot to await.
5667859
@portalBlock
Fix owvoice cog issues.
29b04e9
@portalBlock
Used a relative time not anchored time, oops.
e38d167
@portalBlock
Remove ow naming.
55c6fd4
@portalBlock
Standardize the command to set log channels.
5ae3dc5
@portalBlock
Add the base for MessageWatch - config only, no logic.
6886791
@portalBlock
Complete most of the MessageWatch implementation. Entirely untested.
f3416a6
@portalBlock
Make things async.
1d2f20a
@portalBlock
Typo
ccaaa1a
@portalBlock
Change context, update/standardize naming.
3c3bb23
@portalBlock
For to await
d0385db
@portalBlock
Typo
7a33dd1
@portalBlock
Correct timezone for comparison
fb2cb4e
@portalBlock
Correct timezone for comparison
eecbfe3
@portalBlock portalBlock added the new-cog New cog for bot. label May 23, 2023
@portalBlock portalBlock requested review from tigattack and issy May 23, 2023 21:02
@portalBlock portalBlock linked an issue May 23, 2023 that may be closed by this pull request
[FEAT] Implement Overwatch Functions in a Cog #220
Open
4 tasks
@issy
Copy link
Member

issy commented May 25, 2023

I think these cogs should be combined into one cog. Multiple command groups, sure.

issy
issy requested changes May 29, 2023
View reviewed changes
Copy link
Member

@issy issy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall implementation looks good - just some comments around ergonomics and such. I think ideally I would like to see config and caches as wrapper classes with defined methods. This makes it much clearer how this thing is intended to be used, as we may expand on this later. With the size of this cog, I think that makes a lot of sense. Let me know what you think. Happy to help with any implementation details. Thank you for fleshing this feature out.

voicewatch/voicewatch.py Show resolved Hide resolved
voicewatch/voicewatch.py Show resolved Hide resolved
voicewatch/voicewatch.py Show resolved Hide resolved
messagewatch/messagewatch.py Show resolved Hide resolved
profilewatch/profilewatch.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issy issy issy requested changes

@tigattack tigattack Awaiting requested review from tigattack

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new-cog New cog for bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Implement Overwatch Functions in a Cog
2 participants
@portalBlock @issy