prep for release

r-lib · Dec 6, 2024 · ef1408f · ef1408f
1 parent 74f5f78
commit ef1408f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 142 deletions.
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,21 +1,10 @@
-This is a minor release with a full rewrite of the R facing shaping algorithm.
-It breaks one reverse dependency where the maintainer are waiting for this 
-version to arrive on CRAN before fixing it
+This is a patch release with a bug fix in the shaping code along with better
+guards around indexing zero-length arrays and vectors in the compiled code
 
 ## revdepcheck results
 
-We checked 3 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
+We checked 4 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
 
- * We saw 1 new problems
+ * We saw 0 new problems
  * We failed to check 0 packages
 
-Issues with CRAN packages are summarised below.
-
-### New problems
-(This reports the first line of each new failure)
-
-* geomtextpath
-  checking examples ... ERROR
-  checking tests ... ERROR
-  checking running R code from vignettes ... ERROR
-  checking re-building of vignette outputs ... NOTE
diff --git a/revdep/README.md b/revdep/README.md
@@ -1,8 +1,2 @@
 # Revdeps
 
-## New problems (1)
-
-|package      |version |error  |warning |note   |
-|:------------|:-------|:------|:-------|:------|
-|[geomtextpath](problems.md#geomtextpath)|0.1.3   |__+3__ |        |__+1__ |
-
diff --git a/revdep/cran.md b/revdep/cran.md
@@ -1,18 +1,7 @@
 ## revdepcheck results
 
-We checked 3 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
+We checked 4 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
 
- * We saw 1 new problems
+ * We saw 0 new problems
  * We failed to check 0 packages
 
-Issues with CRAN packages are summarised below.
-
-### New problems
-(This reports the first line of each new failure)
-
-* geomtextpath
-  checking examples ... ERROR
-  checking tests ... ERROR
-  checking running R code from vignettes ... ERROR
-  checking re-building of vignette outputs ... NOTE
-
diff --git a/revdep/problems.md b/revdep/problems.md
@@ -1,108 +1 @@
-# geomtextpath
-
-<details>
-
-* Version: 0.1.3
-* GitHub: https://github.com/AllanCameron/geomtextpath
-* Source code: https://github.com/cran/geomtextpath
-* Date/Publication: 2024-03-12 16:30:03 UTC
-* Number of recursive dependencies: 94
-
-Run `revdepcheck::cloud_details(, "geomtextpath")` for more info
-
-</details>
-
-## Newly broken
-
-*   checking examples ... ERROR
-    ```
-    Running examples in ‘geomtextpath-Ex.R’ failed
-    The error most likely occurred in:
-    
-    > ### Name: coord_curvedpolar
-    > ### Title: Polar coordinates with curved text on x axis
-    > ### Aliases: coord_curvedpolar
-    > 
-    > ### ** Examples
-    > 
-    > 
-    ...
-     20. │                       └─tibble:::`[.tbl_df`(txt$shape, , shape_vars)
-     21. │                         └─tibble:::vectbl_as_col_location(...)
-     22. │                           ├─tibble:::subclass_col_index_errors(...)
-     23. │                           │ └─base::withCallingHandlers(...)
-     24. │                           └─vctrs::vec_as_location(j, n, names, missing = "error", call = call)
-     25. └─vctrs (local) `<fn>`()
-     26.   └─vctrs:::stop_subscript_oob(...)
-     27.     └─vctrs:::stop_subscript(...)
-     28.       └─rlang::abort(...)
-    Execution halted
-    ```
-
-*   checking tests ... ERROR
-    ```
-      Running ‘testthat.R’
-    Running the tests in ‘tests/testthat.R’ failed.
-    Complete output:
-      > library(testthat)
-      > library(geomtextpath)
-      Loading required package: ggplot2
-      > 
-      > test_check("geomtextpath")
-      [ FAIL 35 | WARN 35 | SKIP 3 | PASS 318 ]
-      
-    ...
-        9. │           │ └─base::withCallingHandlers(...)
-       10. │           └─vctrs::vec_as_location(j, n, names, missing = "error", call = call)
-       11. └─vctrs (local) `<fn>`()
-       12.   └─vctrs:::stop_subscript_oob(...)
-       13.     └─vctrs:::stop_subscript(...)
-       14.       └─rlang::abort(...)
-      
-      [ FAIL 35 | WARN 35 | SKIP 3 | PASS 318 ]
-      Error: Test failures
-      Execution halted
-    ```
-
-*   checking running R code from vignettes ... ERROR
-    ```
-    Errors in running code in vignettes:
-    when running code in ‘aesthetics.Rmd’
-      ...
-    
-    > p + geom_textpath(size = 4)
-    
-      When sourcing ‘aesthetics.R’:
-    Error: Problem while converting geom to grob.
-    ℹ Error occurred in the 1st layer.
-    Caused by error in `txt$shape[, shape_vars]`:
-    ...
-    Error: Problem while converting geom to grob.
-    ℹ Error occurred in the 1st layer.
-    Caused by error in `txt$shape[, shape_vars]`:
-    ! Can't subset columns that don't exist.
-    ✖ Column `x_midpoint` doesn't exist.
-    Execution halted
-    
-      ‘aesthetics.Rmd’ using ‘UTF-8’... failed
-      ‘curved_polar.Rmd’ using ‘UTF-8’... failed
-      ‘geomtextpath.Rmd’ using ‘UTF-8’... failed
-    ```
-
-*   checking re-building of vignette outputs ... NOTE
-    ```
-    Error(s) in re-building vignettes:
-    --- re-building ‘aesthetics.Rmd’ using rmarkdown
-    
-    Quitting from lines 40-53 [unnamed-chunk-2] (aesthetics.Rmd)
-    Error: processing vignette 'aesthetics.Rmd' failed with diagnostics:
-    Problem while converting geom to grob.
-    ℹ Error occurred in the 1st layer.
-    Caused by error in `txt$shape[, shape_vars]`:
-    ! Can't subset columns that don't exist.
-    ✖ Column `x_midpoint` doesn't exist.
-    --- failed re-building ‘aesthetics.Rmd’
-    
-    --- re-building ‘curved_polar.Rmd’ using rmarkdown
-    ```
-
+*Wow, no problems at all. :)*