Feature/29 convert wl_convert_units() to generic
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GegznaV
commented
Aug 12, 2021
| wl(x) <- wl_new | ||
|
|
||
| x@label$.wavelength <- | ||
| switch(.wl_fix_unit_name(to), |
There was a problem hiding this comment.
Create a separate function that is based on this switch sentence.
There was a problem hiding this comment.
This will be addressed in a separate PR. See:
bryanhanson
reviewed
Aug 12, 2021
There was a problem hiding this comment.
Alright, if I understand this function I see 2 items for your consideration:
- This line
#' @param x Data for conversion.would be clearer if it read#' @param x Data to be converted. Either a hyperSpec object or a numeric or integer vector. - This UT
test_that("wl_convert_units.hyperSpec works", {actually tests both...units.hyperSpecand...units.defaultYou may wish to separate them.
I leave it up to you to decide if these items are worth changing. OK to merge either way.
|
Thank you, @bryanhanson, for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29