Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move analytics to Gradle scripts and minor cleanup #2977

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Nov 30, 2024

No description provided.

Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  24.1 MiB │  24.1 MiB │ -2.6 KiB │  74.7 MiB │  74.7 MiB │ -6.8 KiB 
     arsc │   2.7 MiB │   2.7 MiB │      0 B │   2.7 MiB │   2.7 MiB │      0 B 
 manifest │   5.8 KiB │   5.8 KiB │      0 B │    28 KiB │    28 KiB │      0 B 
      res │   1.7 MiB │   1.7 MiB │     +2 B │     2 MiB │     2 MiB │      0 B 
   native │  18.8 KiB │  18.8 KiB │      0 B │  36.5 KiB │  36.5 KiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │   218 KiB │   218 KiB │    +24 B │ 464.3 KiB │ 464.3 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  29.2 MiB │  29.2 MiB │ -2.5 KiB │  80.5 MiB │  80.5 MiB │ -6.8 KiB 

Copy link

New Dependencies
androidx.datastore:datastore:1.0.0
androidx.datastore:datastore-core:1.0.0
androidx.datastore:datastore-preferences:1.0.0
androidx.datastore:datastore-preferences-core:1.0.0
androidx.privacysandbox.ads:ads-adservices:1.0.0-beta05
androidx.privacysandbox.ads:ads-adservices-java:1.0.0-beta05
com.google.android.datatransport:transport-api:3.2.0
com.google.android.datatransport:transport-backend-cct:3.3.0
com.google.android.datatransport:transport-runtime:3.3.0
com.google.android.gms:play-services-ads-identifier:18.0.0
com.google.android.gms:play-services-base:18.5.0
com.google.android.gms:play-services-basement:18.4.0
com.google.android.gms:play-services-measurement:22.1.2
com.google.android.gms:play-services-measurement-api:22.1.2
com.google.android.gms:play-services-measurement-base:22.1.2
com.google.android.gms:play-services-measurement-impl:22.1.2
com.google.android.gms:play-services-measurement-sdk:22.1.2
com.google.android.gms:play-services-measurement-sdk-api:22.1.2
com.google.android.gms:play-services-stats:17.0.2
com.google.android.gms:play-services-tasks:18.2.0
com.google.code.findbugs:jsr305:3.0.2
com.google.firebase:firebase-analytics:22.1.2
com.google.firebase:firebase-analytics-ktx:22.1.2
com.google.firebase:firebase-annotations:16.2.0
com.google.firebase:firebase-common:21.0.0
com.google.firebase:firebase-common-ktx:21.0.0
com.google.firebase:firebase-components:18.0.0
com.google.firebase:firebase-config-interop:16.0.1
com.google.firebase:firebase-crashlytics:19.2.1
com.google.firebase:firebase-datatransport:19.0.0
com.google.firebase:firebase-encoders:17.0.0
com.google.firebase:firebase-encoders-json:18.0.1
com.google.firebase:firebase-encoders-proto:16.0.0
com.google.firebase:firebase-installations:18.0.0
com.google.firebase:firebase-installations-interop:17.2.0
com.google.firebase:firebase-measurement-connector:20.0.1
com.google.firebase:firebase-sessions:2.0.6
com.google.j2objc:j2objc-annotations:3.0.0
org.checkerframework:checker-qual:3.43.0
org.jetbrains.kotlinx:kotlinx-coroutines-play-services:1.9.0
project :feature:firebase-analytics

Removed Dependencies
project :feature:analytics-noop

Upgraded Dependencies
com.google.errorprone:error_prone_annotations:2.28.0, (changed from 2.15.0)

@ahmedre
Copy link
Contributor Author

ahmedre commented Nov 30, 2024

:app:dependencies runs with --configuration madaniReleaseRuntimeClasspath, which is why this now shows Firebase dependencies, since we don't pass the disableFirebase or the disableCrashlytics.

@ahmedre ahmedre added this pull request to the merge queue Nov 30, 2024
Merged via the queue into main with commit 34be838 Nov 30, 2024
2 checks passed
@ahmedre ahmedre deleted the gradle_cleanup branch November 30, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant