Merge pull request #2494 from quran/fix_inefficient_lookup

Avoid unnecessary reads of translations data
quran · Dec 10, 2023 · 7ff6771 · 7ff6771
2 parents 54cf9f6 + c4993f0
commit 7ff6771
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...main/java/com/quran/labs/androidquran/presenter/translation/InlineTranslationPresenter.kt b/...main/java/com/quran/labs/androidquran/presenter/translation/InlineTranslationPresenter.kt
@@ -21,7 +21,7 @@ class InlineTranslationPresenter @Inject constructor(
   dbAdapter: TranslationsDBAdapter,
   translationUtil: TranslationUtil,
   private val quranSettings: QuranSettings,
-  private val translationListPresenter: TranslationListPresenter,
+  translationListPresenter: TranslationListPresenter,
   quranInfo: QuranInfo
 ) : BaseTranslationPresenter<InlineTranslationPresenter.TranslationScreen>(
   translationModel, dbAdapter, translationUtil, quranInfo

diff --git a/app/src/main/java/com/quran/labs/androidquran/ui/fragment/AyahActionFragment.kt b/app/src/main/java/com/quran/labs/androidquran/ui/fragment/AyahActionFragment.kt
@@ -34,14 +34,18 @@ abstract class AyahActionFragment : Fragment() {
     scope = MainScope()
     readingEventPresenter.ayahSelectionFlow
       .combine(audioEventPresenter.audioPlaybackAyahFlow) { selectedAyah, playbackAyah ->
+        val (previousStart, previousEnd) = start to end
         if (selectedAyah !is AyahSelection.None) {
           start = selectedAyah.startSuraAyah()
           end = selectedAyah.endSuraAyah()
         } else if (playbackAyah != null) {
           start = playbackAyah
           end = playbackAyah
         }
-        refreshView()
+
+        if (previousStart != start || previousEnd != end) {
+          refreshView()
+        }
       }
       .launchIn(scope)