Add additional tests for document validation. Correct typos

quintush · Jan 2, 2023 · 83cff9e · 83cff9e
1 parent e35f027
commit 83cff9e
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/pkg/unittest/validators/contains_document_validator.go b/pkg/unittest/validators/contains_document_validator.go
@@ -80,8 +80,8 @@ func (v ContainsDocumentValidator) Validate(context *ValidateContext) (bool, []s
 		continue
 	}
 	if !validateSuccess {
-		errorMesasge := v.failInfo(v.Kind, 0, context.Negative)
-		validateErrors = append(validateErrors, errorMesasge...)
+		errorMessage := v.failInfo(v.Kind, 0, context.Negative)
+		validateErrors = append(validateErrors, errorMessage...)
 	}
 	validateSuccess = determineSuccess(1, validateSuccess, true)
 

diff --git a/pkg/unittest/validators/contains_document_validator_test.go b/pkg/unittest/validators/contains_document_validator_test.go
@@ -112,7 +112,7 @@ func TestContainsDocumentValidatorNoNameNamespaceWhenOk(t *testing.T) {
 	assert.Equal(t, []string{}, diff)
 }
 
-func TestContainsDocumentValidatorWhenFail(t *testing.T) {
+func TestContainsDocumentValidatorWhenFailKind(t *testing.T) {
 	validator := ContainsDocumentValidator{
 		"Deployment",
 		"apps/v1",
@@ -133,3 +133,25 @@ func TestContainsDocumentValidatorWhenFail(t *testing.T) {
 		"\tKind = Deployment, apiVersion = apps/v1",
 	}, diff)
 }
+
+func TestContainsDocumentValidatorWhenFailAPIVersion(t *testing.T) {
+	validator := ContainsDocumentValidator{
+		"Service",
+		"apps/v1",
+		"foo",
+		"bar",
+	}
+
+	pass, diff := validator.Validate(&ValidateContext{
+		Index: -1,
+		Docs: []common.K8sManifest{makeManifest(docToTestContainsDocument1),
+			makeManifest(docToTestContainsDocument2)},
+	})
+
+	assert.False(t, pass)
+	assert.Equal(t, []string{
+		"DocumentIndex:\t0",
+		"Expected to contain document:",
+		"\tKind = Service, apiVersion = apps/v1",
+	}, diff)
+}