Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement trace of FermionOperator #349

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Implement trace of FermionOperator #349

wants to merge 17 commits into from

Conversation

minhctran
Copy link

Fixes #348

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kevinsung
kevinsung requested changes Jan 9, 2025
View reviewed changes
tests/python/operators/trace_test.py Outdated Show resolved Hide resolved
tests/python/operators/trace_test.py Outdated Show resolved Hide resolved
tests/python/operators/trace_test.py Outdated Show resolved Hide resolved
tests/python/operators/trace_test.py Outdated Show resolved Hide resolved
tests/python/operators/trace_test.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
kevinsung
kevinsung requested changes Jan 9, 2025
View reviewed changes
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
@kevinsung kevinsung changed the title Fixed issue 348: implement trace of FermionOperator Implement trace of FermionOperator Jan 9, 2025
kevinsung
kevinsung requested changes Jan 9, 2025
View reviewed changes
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
kevinsung
kevinsung requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@kevinsung kevinsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a few more things.

tests/python/operators/trace_test.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
kevinsung
kevinsung reviewed Jan 10, 2025
View reviewed changes
tests/python/operators/trace_test.py Outdated Show resolved Hide resolved
tests/python/operators/trace_test.py Outdated Show resolved Hide resolved
kevinsung
kevinsung reviewed Jan 10, 2025
View reviewed changes
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
python/ffsim/protocols/trace_protocol.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinsung kevinsung kevinsung requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement trace for FermionOperator
3 participants
@minhctran @CLAassistant @kevinsung