support parse_as_double #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 44.74% 44.77% +0.03%
==========================================
Files 45 45
Lines 5466 5469 +3
==========================================
+ Hits 2446 2449 +3
Misses 3020 3020 ☔ View full report in Codecov by Sentry. |
qicosmos
reviewed
Jan 22, 2024
iguana/json_reader.hpp
Outdated
| @@ -634,10 +634,10 @@ IGUANA_INLINE void from_json(T &value, const Byte *data, size_t size, | |||
| } | |||
| } | |||
|
|
|||
| template <bool Is_view = false, typename It> | |||
| template <bool parse_as_double = false, bool Is_view = false, typename It> | |||
There was a problem hiding this comment.
parse_as_double 作为函数参数吧，默认为false，模版参数有点多了，而且这个也不需要编译期bool，运行期就好了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set parse_as_double == true, the dom parse of iguana will parse number as double type in any case