Hide zero and infinity values in peer list only when that setting is set to Always
#22205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set to `Always` Closes qbittorrent#21998.
glassez
approved these changes
Jan 25, 2025
glassez
reviewed
Jan 25, 2025
| @@ -420,7 +420,8 @@ void PeerListWidget::loadPeers(const BitTorrent::Torrent *torrent) | |||
| for (auto i = m_peerItems.cbegin(); i != m_peerItems.cend(); ++i) | |||
| existingPeers.insert(i.key()); | |||
|
|
|||
| const bool hideZeroValues = Preferences::instance()->getHideZeroValues(); | |||
| const Preferences *pref = Preferences::instance(); | |||
| const bool hideZeroValues = (pref->getHideZeroValues() && (pref->getHideZeroComboValues() == 0)); | |||
There was a problem hiding this comment.
That would be nice to refactor it further in order to have single accessor using enum type.
There was a problem hiding this comment.
That would be nice to refactor it further in order to have single accessor using
enumtype.
Unfortunately i don't know what this means.
There was a problem hiding this comment.
That would be nice to refactor it further in order to have single accessor using
enumtype.Unfortunately i don't know what this means.
This is more of a note for myself...
glassez
approved these changes
Jan 25, 2025
Chocobo1
approved these changes
Jan 25, 2025
xavier2k6
approved these changes
Jan 25, 2025
|
@thalieht |
glassez
pushed a commit
to glassez/qBittorrent
that referenced
this pull request
Jan 27, 2025
…set to `Always` PR qbittorrent#22205. Closes qbittorrent#21998.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21998.