[Feature,Refactor] Chess improvements: fen, pgn, pixels, san #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2702
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 7 Pending, 2 Unrelated FailuresAs of commit 6f1d43d with merge base 256a700 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 17, 2025
vmoens
added a commit
that referenced
this pull request
Jan 17, 2025
ghstack-source-id: 81dba82c14ae94c3c25b1a2e78fc3b478cddcc8d Pull Request resolved: #2702
facebook-github-bot
added
the
CLA Signed
vmoens
added
enhancement
vmoens
added a commit
that referenced
this pull request
Jan 17, 2025
ghstack-source-id: 87c458ebe69a21569719d12ad17fb3d7a356da0d Pull Request resolved: #2702
kurtamohler
reviewed
Jan 17, 2025
| @@ -90,28 +115,76 @@ class ChessEnv(EnvBase): | |||
| """ | |||
|
|
|||
| _hash_table: Dict[int, str] = {} | |||
| _PNG_RESTART = """[Event "?"] | |||
There was a problem hiding this comment.
nit:
Suggested change
| _PNG_RESTART = """[Event "?"] | |
| _PGN_RESTART = """[Event "?"] |
kurtamohler
reviewed
Jan 17, 2025
| # Generate the PGN string | ||
| pgn_string = str(game) | ||
| return pgn_string | ||
|
|
||
| @classmethod | ||
| def _get_fen(cls, tensordict): |
There was a problem hiding this comment.
Maybe this function can be removed, in favor of a direct TensorDict.get call?
kurtamohler
reviewed
Jan 17, 2025
| fen = self._get_fen(tensordict).data | ||
| dest = tensordict.empty() | ||
| if self.include_pgn: | ||
| fen = self._get_pgn(tensordict).data |
There was a problem hiding this comment.
Suggested change
| fen = self._get_pgn(tensordict).data | |
| pgn = self._get_pgn(tensordict).data |
Also _get_pgn doesn't exist, but I figure you realize that
kurtamohler
reviewed
Jan 17, 2025
| @classmethod | ||
| def _get_tensor_image(cls, board): | ||
| try: | ||
| svg = board._repr_svg_() |
There was a problem hiding this comment.
Maybe we could have another option that has a more minimal representation as well, if we want to train without vision. For instance, OpenSpiel's chess env has a representation where each square of the board is given a size 20 array of ones and zeros, which is somehow used to represent which piece is in that square and which color it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
example_datafor NonTensor spec #2698