Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm unittest refactor of Add and Conv2D test cases #7541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AdrianLundell
Copy link
Collaborator

This is a showcase of multiple improvements which can be done across all tests:

  1. Move pipeline definition from tests to a general (flexible) pipeline class
  • Define a default step of stages using e.g. TosaPipelineBI()
  • Add custom config or debug stages using helper functions s.a. .change_args(), .add_stage(), .dump_artifact() etc.
  • Run the full pipeline using .run()
  1. Move towards a pure pytest approach to remove dependencies on unittest and parametrize
  2. Separate tests running on FVP from tests not running on FVP rather than configuring this from the command line
  • FVP tests are skipped if not installed
  • To filter out tests one may instead use pytest markers/name filtering
  • This should give a clearer picture of what has been tested
  1. Introduces one favored way of marking tests as xfails, in the parameterize decorator

This is a showcase of multiple improvements which can be done across all tests:
1. Move pipeline definition from tests to a general (flexible) pipeline class
  - Define a default step of stages using e.g. TosaPipelineBI()
  - Add custom config or debug stages using helper functions s.a. .change_args(), .add_stage(), .dump() etc.
  - Run the full pipeline using .run()
2. Move towards a pure pytest approach to remove dependencies on unittest and parametrize
3. Separate tests running on FVP from tests not running on FVP rather than configuring this from the command line
  - FVP tests are skipped if not installed
  - To filter out tests one may instead use pytest markers/name filtering
  - This should give a clearer picture of what has been tested
4. Introduces one favored way of marking tests as xfails, in the parameterize decorator

Change-Id: Ieb88209fd7bcbb4b700bb970d6877ca6785752a4
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Jan 7, 2025
Copy link

pytorch-bot bot commented Jan 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7541

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 1795dff with merge base a29dc49 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2025
@AdrianLundell
Copy link
Collaborator Author

@digantdesai Curious to see what you think about this, in particular this removes unittest support in favour of a simpler pytest-only setup + it introduces one extra layer of complexity by wrapping test stages in the new test_pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants