Log EValue tag names instead of numeric values #7538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7538
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit aa81d29 with merge base 91f09aa ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67888756 |
GregoryComer
force-pushed
the
export-D67888756
branch
from
6c2529a to
9dc157d
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
manuelcandales
approved these changes
Jan 8, 2025
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 19, 2025
Summary: Update error log messages that include EValue tags to use a string representation of the tag rather than the numerical index. This improves readability for users. Example Old Message: ``` [method.cpp:814] The 0-th input of method should have the same type as the input_evalue, but get tag 1 and tag 4 ``` Example New Message: ``` [method.cpp:813] Input 0 was expected to be Tensor but was Int. ``` Test Plan: Locally built the executorch bento kernel and tested with an invalid EValue input to capture the example new message above. Repeated with "-c executorch.enable_enum_strings=false" to verify fallback behavior. Added tests for `tag_to_string` to tag_test.cpp, runnable via ``` buck test executorch/runtime/core/test:tag_test ``` Reviewed By: digantdesai, manuelcandales Differential Revision: D67888756 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67888756
branch
from
9dc157d to
7e46386
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67888756 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67888756 |
GregoryComer
force-pushed
the
export-D67888756
branch
from
7e46386 to
32632c3
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 21, 2025
Summary: Update error log messages that include EValue tags to use a string representation of the tag rather than the numerical index. This improves readability for users. Example Old Message: ``` [method.cpp:814] The 0-th input of method should have the same type as the input_evalue, but get tag 1 and tag 4 ``` Example New Message: ``` [method.cpp:813] Input 0 was expected to be Tensor but was Int. ``` Pull Request resolved: pytorch#7538 Test Plan: Locally built the executorch bento kernel and tested with an invalid EValue input to capture the example new message above. Repeated with "-c executorch.enable_enum_strings=false" to verify fallback behavior. Added tests for `tag_to_string` to tag_test.cpp, runnable via ``` buck test executorch/runtime/core/test:tag_test ``` Reviewed By: digantdesai, manuelcandales Differential Revision: D67888756 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 21, 2025
Summary: Update error log messages that include EValue tags to use a string representation of the tag rather than the numerical index. This improves readability for users. Example Old Message: ``` [method.cpp:814] The 0-th input of method should have the same type as the input_evalue, but get tag 1 and tag 4 ``` Example New Message: ``` [method.cpp:813] Input 0 was expected to be Tensor but was Int. ``` Pull Request resolved: pytorch#7538 Test Plan: Locally built the executorch bento kernel and tested with an invalid EValue input to capture the example new message above. Repeated with "-c executorch.enable_enum_strings=false" to verify fallback behavior. Added tests for `tag_to_string` to tag_test.cpp, runnable via ``` buck test executorch/runtime/core/test:tag_test ``` Reviewed By: digantdesai, manuelcandales Differential Revision: D67888756 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67888756
branch
from
32632c3 to
74fd01f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67888756 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 22, 2025
Summary: Update error log messages that include EValue tags to use a string representation of the tag rather than the numerical index. This improves readability for users. Example Old Message: ``` [method.cpp:814] The 0-th input of method should have the same type as the input_evalue, but get tag 1 and tag 4 ``` Example New Message: ``` [method.cpp:813] Input 0 was expected to be Tensor but was Int. ``` Test Plan: Locally built the executorch bento kernel and tested with an invalid EValue input to capture the example new message above. Repeated with "-c executorch.enable_enum_strings=false" to verify fallback behavior. Added tests for `tag_to_string` to tag_test.cpp, runnable via ``` buck test executorch/runtime/core/test:tag_test ``` Reviewed By: digantdesai, manuelcandales, dbort Differential Revision: D67888756 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67888756
branch
from
74fd01f to
b80e3b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67888756 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 22, 2025
Summary: Update error log messages that include EValue tags to use a string representation of the tag rather than the numerical index. This improves readability for users. Example Old Message: ``` [method.cpp:814] The 0-th input of method should have the same type as the input_evalue, but get tag 1 and tag 4 ``` Example New Message: ``` [method.cpp:813] Input 0 was expected to be Tensor but was Int. ``` Test Plan: Locally built the executorch bento kernel and tested with an invalid EValue input to capture the example new message above. Repeated with "-c executorch.enable_enum_strings=false" to verify fallback behavior. Added tests for `tag_to_string` to tag_test.cpp, runnable via ``` buck test executorch/runtime/core/test:tag_test ``` Reviewed By: digantdesai, manuelcandales, dbort Differential Revision: D67888756 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67888756
branch
from
b80e3b5 to
6493a92
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67888756 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 22, 2025
Summary: Update error log messages that include EValue tags to use a string representation of the tag rather than the numerical index. This improves readability for users. Example Old Message: ``` [method.cpp:814] The 0-th input of method should have the same type as the input_evalue, but get tag 1 and tag 4 ``` Example New Message: ``` [method.cpp:813] Input 0 was expected to be Tensor but was Int. ``` Test Plan: Locally built the executorch bento kernel and tested with an invalid EValue input to capture the example new message above. Repeated with "-c executorch.enable_enum_strings=false" to verify fallback behavior. Added tests for `tag_to_string` to tag_test.cpp, runnable via ``` buck test executorch/runtime/core/test:tag_test ``` Reviewed By: digantdesai, manuelcandales, dbort Differential Revision: D67888756 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67888756
branch
from
6493a92 to
d87b878
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67888756 |
Summary: Update error log messages that include EValue tags to use a string representation of the tag rather than the numerical index. This improves readability for users. Example Old Message: ``` [method.cpp:814] The 0-th input of method should have the same type as the input_evalue, but get tag 1 and tag 4 ``` Example New Message: ``` [method.cpp:813] Input 0 was expected to be Tensor but was Int. ``` Test Plan: Locally built the executorch bento kernel and tested with an invalid EValue input to capture the example new message above. Repeated with "-c executorch.enable_enum_strings=false" to verify fallback behavior. Added tests for `tag_to_string` to tag_test.cpp, runnable via ``` buck test executorch/runtime/core/test:tag_test ``` Reviewed By: digantdesai, manuelcandales, dbort Differential Revision: D67888756 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67888756
branch
from
d87b878 to
aa81d29
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67888756 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update error log messages that include EValue tags to use a string representation of the tag rather than the numerical index. This improves readability for users.
Example Old Message:
Example New Message:
Differential Revision: D67888756