Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests to demonstrate queries using alias #365

Merged
merged 3 commits into from
Oct 23, 2018
Merged

add tests to demonstrate queries using alias #365

merged 3 commits into from
Oct 23, 2018

Conversation

wwwjfy
Copy link
Member

@wwwjfy wwwjfy commented Oct 21, 2018

  • multiple models are in one subquery
  • aggregation functions are used in queries

related to #330

@wwwjfy
add tests to demonstrate queries using alias
126fecc 
- multiple models are in one subquery
- aggregation functions are used in queries
@coveralls
Copy link

coveralls commented Oct 21, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1296

  • 34 of 34 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 98.308%
Totals Coverage Status
Change from base Build 1289: 0.01%
Covered Lines: 4008
Relevant Lines: 4077
💛 - Coveralls

@wwwjfy wwwjfy mentioned this pull request Oct 21, 2018
Open
fantix
fantix approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'll also add this to docs.

@wwwjfy wwwjfy merged commit fd0d2df into python-gino:master Oct 23, 2018
@wwwjfy wwwjfy deleted the alias-loader branch October 23, 2018 03:39
fantix added a commit that referenced this pull request Oct 25, 2018
@fantix
Fixes #308, refs #365, update docs
5c192a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantix fantix fantix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wwwjfy @coveralls @fantix