Add AlignedSegment.__repr__ #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am-developers#1267) Example output: <AlignedSegment('name', flags=16=0x10, ref='chr1', zpos=1170070, mapq=255, cigar='50M', ...)> [Use an f-string; write flags in hex too; and use 'zpos' label to emphasis this field is shown 0-based. -- JM]
jmarshall
force-pushed
the
alignedsegment-repr
branch
from
231604d to
9a694d0
Compare
|
Thanks, I like it. I've reworked it a little to use f-strings (now that we assume Py3.6, they're available!) and label the position as |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
I’ve used pysam with this patch for a while and find it very valuable when looking at
AlignedSegments in a debugger or the REPL.I’ve chosen to include only the (from my perspective) most important attributes so that the output doesn’t become too long, in particular when there’s a list with
AlignedSegments.The angle brackets are supposed to convey that the string cannot be passed to
eval()to recreate the object. I’d be fine with removing them.