Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct in-line ruff syntax #660

Merged
merged 5 commits into from
Nov 19, 2023
Merged

Conversation

jGaboardi
Copy link
Member

xref #589

This PR corrects in-line ruff syntax in common.py.

# noqa <CODE> to # noqa: <CODE>

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #660 (c8d3c89) into main (3816631) will increase coverage by 0.0%.
The diff coverage is 68.5%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #660   +/-   ##
=====================================
  Coverage   85.0%   85.0%           
=====================================
  Files        139     139           
  Lines      14889   14889           
=====================================
+ Hits       12659   12663    +4     
+ Misses      2230    2226    -4     
Files Coverage Δ
libpysal/cg/alpha_shapes.py 85.7% <100.0%> (ø)
libpysal/cg/locators.py 60.1% <ø> (ø)
libpysal/cg/ops/tabular.py 62.2% <100.0%> (ø)
libpysal/cg/ops/tests/test_tabular.py 100.0% <100.0%> (ø)
libpysal/cg/rtree.py 90.9% <100.0%> (ø)
libpysal/cg/sphere.py 72.9% <100.0%> (ø)
libpysal/cg/standalone.py 91.3% <100.0%> (ø)
libpysal/cg/tests/test_sphere.py 100.0% <100.0%> (ø)
libpysal/cg/voronoi.py 88.6% <ø> (ø)
libpysal/examples/tests/test_available.py 96.8% <100.0%> (+6.5%) ⬆️
... and 46 more

@martinfleis
Copy link
Member

I just did global find and replace to tackle it across the codebase. It is all the same change, there's no need to split it by file or folder.

@martinfleis martinfleis changed the title correct in-line ruff syntax in common.py correct in-line ruff syntax Nov 19, 2023
@martinfleis martinfleis merged commit 9e45960 into pysal:main Nov 19, 2023
10 checks passed
@jGaboardi jGaboardi deleted the noqa_colon_top_level branch November 19, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants