-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint & format – io/iohandlers/*
#630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #630 +/- ##
=====================================
Coverage 84.2% 84.2%
=====================================
Files 139 139
Lines 14897 14897
=====================================
Hits 12550 12550
Misses 2347 2347
|
jGaboardi
commented
Nov 5, 2023
This was referenced Nov 9, 2023
martinfleis
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martinfleis small fix left here inside
libpysal/graph/tests/test_utils.py
from dd4b7d2 last week. Merge here or open a different PR?EDIT
Broken out into parts:
io/iohandlers{a-d}.py
#637io/iohandlers{g-m}
.py #638io/iohandlers{p-s}.py
#641io/iohandlers{t-w}
.py #642io/iohandlers/tests/*.py
#643I'll close this PR once completed in broken out sections.
xref #589
This PR formats and lints
libpysal/io/iohandlers/*
EDIT
@martinfleis This one ended up with a much larger diff that I had thought it would. I can split into 2 or 3 separate PRs if that would be better for you. Let me know.