More updates for future-proofing #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let pip handle all the dependencies while installing this package
|
Pysph performance is not tested. |
nauaneed
force-pushed
the
bump-cython-old
branch
from
26df668 to
7aabc02
Compare
prabhuramachandran
requested changes
Dec 13, 2024
cyarray/carray.pyx.mako
Outdated
|
|
||
| cpdef reserve(self, long size): | ||
| """Resizes the internal data to required size. | ||
| """ | ||
| raise NotImplementedError, 'BaseArray::reserve' | ||
| raise NotImplementedError(BaseArray::reserve') |
There was a problem hiding this comment.
Please fix this error and the other one.
prabhuramachandran
approved these changes
Dec 13, 2024
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.