Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: environment name should be pypi #17381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lwasser
Copy link

@lwasser lwasser commented Jan 9, 2025

Addresses #17374

This pr updates the screenshots for trusted publisher to ensure the environment name is listed as pypi rather than release.

Dev instructions were tricky to follow

Friends, I wasn't able to get docker to run as expected. I first went down a rabbit hole that I realized was building the entire warehouse. I did this because the README suggested that I follow the detailed instructions, but i think that I should have only followed the

  • git/clone part
  • docker compose setup part (i already have docker installed but not all users will)

I wonder if it's worth adding a note in the dev docs that says - if you want to only build the docs - go to (and add links to the readme for the user docs). I'm still wrapping my head around your setup, so this could also be my misunderstanding.

Let me know, however, if this PR seems ok. It's just image updates so in theory i shouldn't need to rebuild the docs locally (but i do want to figure out how to).

@lwasser
Copy link
Author

lwasser commented Jan 9, 2025

ok yay for CI -- it seems like it's rendering ok 🚀
https://docspypiorg--17381.org.readthedocs.build/trusted-publishers/creating-a-project-through-oidc/

@lwasser lwasser marked this pull request as ready for review January 9, 2025 23:31
@lwasser lwasser requested a review from a team as a code owner January 9, 2025 23:31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a subtle difference with this one: the "Environment name" field is focused and so it has a blue outline.

Also, for consistency's sake, these screenshots were previously made by taking a "node screenshot" of the enclosed section:

image

Doing this is not strictly necessary but will keep the cropping around the element the same as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants