You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we always use the same callback function, but each step of the Runnable.run cycle flexibly lets child classes define kwargs for each step. This lets us stop passing the callback function as an argument and just always use Runnable._finish_run.
In Node, the new kwargs mean we can move firing the signals over to the _run_finally method, and take advantage of this to add a new failed output signal.
There's a decent amount going on under the hood here, but for users there is no incompatible changes, just the new signal.
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we always use the same callback function, but each step of the
Runnable.run
cycle flexibly lets child classes define kwargs for each step. This lets us stop passing the callback function as an argument and just always useRunnable._finish_run
.In
Node
, the new kwargs mean we can move firing the signals over to the_run_finally
method, and take advantage of this to add a newfailed
output signal.There's a decent amount going on under the hood here, but for users there is no incompatible changes, just the new signal.