Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Runnable flexibility and a new output signal #467

Merged
merged 8 commits into from
Sep 21, 2024
Merged

Conversation

liamhuber
Copy link
Member

Now we always use the same callback function, but each step of the Runnable.run cycle flexibly lets child classes define kwargs for each step. This lets us stop passing the callback function as an argument and just always use Runnable._finish_run.

In Node, the new kwargs mean we can move firing the signals over to the _run_finally method, and take advantage of this to add a new failed output signal.

There's a decent amount going on under the hood here, but for users there is no incompatible changes, just the new signal.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/single_finish

@liamhuber liamhuber added the format_black trigger the Black formatting bot label Sep 21, 2024
Copy link

codacy-production bot commented Sep 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 94.59%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f952807) 3270 2984 91.25%
Head commit (86385bc) 3279 (+9) 2992 (+8) 91.25% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#467) 37 35 94.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Sep 21, 2024

Pull Request Test Coverage Report for Build 10969392791

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.007%) to 91.247%

Files with Coverage Reduction New Missed Lines %
io.py 3 94.21%
mixin/run.py 10 90.2%
node.py 11 90.3%
nodes/standard.py 15 90.96%
Totals Coverage Status
Change from base Build 10968687985: -0.007%
Covered Lines: 2992
Relevant Lines: 3279

💛 - Coveralls

@liamhuber liamhuber merged commit e382ce2 into main Sep 21, 2024
16 checks passed
@liamhuber liamhuber deleted the single_finish branch September 21, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black trigger the Black formatting bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants