Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Detatched path #457

Merged
merged 3 commits into from
Sep 18, 2024
Merged

[patch] Detatched path #457

merged 3 commits into from
Sep 18, 2024

Conversation

liamhuber
Copy link
Member

Let's the my_node.semantic_path retain parent path information even through the __get/setstate__ cycle (e.g. when (un)pickling)

So that semantic parents no longer need to be updating private attributes of their children to avoid the recursion. It was barely tolerable when it was a single attribute, but now that we also track the detached parent path it is totally unacceptable.
@liamhuber liamhuber added the enhancement New feature or request label Sep 18, 2024
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/detatched_path

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 86.36%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f163074) 3231 2950 91.30%
Head commit (4a56f3d) 3244 (+13) 2961 (+11) 91.28% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#457) 22 19 86.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10927016904

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 91.276%

Files with Coverage Reduction New Missed Lines %
mixin/semantics.py 5 96.55%
nodes/composite.py 6 89.95%
Totals Coverage Status
Change from base Build 10887232823: -0.03%
Covered Lines: 2961
Relevant Lines: 3244

💛 - Coveralls

@liamhuber liamhuber merged commit c33c9e1 into main Sep 18, 2024
21 checks passed
@liamhuber liamhuber deleted the detatched_path branch September 18, 2024 17:25
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants