Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Let pint-hinted input values pass through type hinting #451

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

liamhuber
Copy link
Member

By checking the actual datatype associated with their "magnitude".

I'm also boldly going to try setting the lower bound to the last version and hope it works.

Motivated by pyiron/elaston#45

By checking the actual datatype associated with their "magnitude".

I'm also boldly going to try setting the lower bound to the last version and hope it works.
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/pint_support

Copy link

codacy-production bot commented Sep 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (435cf8e) 3229 2948 91.30%
Head commit (d229720) 3231 (+2) 2950 (+2) 91.30% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#451) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Sep 10, 2024

Pull Request Test Coverage Report for Build 10799085556

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 91.303%

Files with Coverage Reduction New Missed Lines %
type_hinting.py 1 97.73%
Totals Coverage Status
Change from base Build 10798950726: 0.005%
Covered Lines: 2950
Relevant Lines: 3231

💛 - Coveralls

Copy link
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this looks perfect to me :)

@liamhuber liamhuber merged commit df56647 into main Sep 10, 2024
17 checks passed
@liamhuber liamhuber deleted the pint_support branch September 10, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants