Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Add a utility to the API for finding node classes #439

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

liamhuber
Copy link
Member

@liamhuber liamhuber commented Aug 30, 2024

Per @JNmpi's request pyiron/pyironFlow@679faf3#r146023624

TODO:

  • unit test
  • demo it somewhere? Maybe the deepdive? It's "hidden" (private) in the API. If the interface settles (next point) we can demo it then.
  • Recursion? Instead of a list we probably want to walk the source and return a nested dictionary. A per-module version is already a step forward. It can be used in pyiron-xyflow (or elsewhere) and we can migrate walking code here if it gets written.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/node_finder

Copy link

codacy-production bot commented Aug 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 92.86%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8dc719b) 3099 2830 91.32%
Head commit (732bb46) 3127 (+28) 2856 (+26) 91.33% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#439) 28 26 92.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

liamhuber referenced this pull request in pyiron/pyironFlow Aug 30, 2024
…ersion (nodes with list of all node functions no longer available, therefore a new parser has been implemented)
@coveralls
Copy link

coveralls commented Aug 30, 2024

Pull Request Test Coverage Report for Build 10693654494

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.334%

Totals Coverage Status
Change from base Build 10585647738: 0.01%
Covered Lines: 2856
Relevant Lines: 3127

💛 - Coveralls

So we can iterate on it while still making weaker semantic version upgrades
And refactor the boolean flag to be in line with the other two
@liamhuber liamhuber added the format_black trigger the Black formatting bot label Sep 4, 2024
@liamhuber liamhuber marked this pull request as ready for review September 4, 2024 01:53
@liamhuber liamhuber merged commit 427733b into main Sep 4, 2024
16 of 17 checks passed
@liamhuber liamhuber deleted the node_finder branch September 4, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black trigger the Black formatting bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants