Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Don't have a default Executor #390

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

liamhuber
Copy link
Member

Make the user choose one specifically.

Make the user choose one specifically.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/no_default_executor

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0e3a558) 3472 3208 92.40%
Head commit (3f1d965) 3470 (-2) 3206 (-2) 92.39% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#390) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@liamhuber liamhuber marked this pull request as ready for review July 24, 2024 17:22
@liamhuber liamhuber merged commit 7ce1cf5 into change_default_executor Jul 24, 2024
17 checks passed
@liamhuber liamhuber deleted the no_default_executor branch July 24, 2024 17:24
liamhuber added a commit that referenced this pull request Jul 24, 2024
* Make ProcessPoolExecutor the default executor -- but use executorlib in notebooks

* [minor] Don't have a default `Executor` (#390)

Make the user choose one specifically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant