Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Rely on the base class to not mangle names by default #227

Closed
wants to merge 1 commit into from

Conversation

liamhuber
Copy link
Member

This reverts #226 in the event that pyiron_base 1358 gets merged and the whole process is handled upstream.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/revert_mangle_exploitation

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b304c69) 3114 2702 86.77%
Head commit (c27d38f) 3113 (-1) 2701 (-1) 86.77% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#227) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@liamhuber
Copy link
Member Author

This won't be necessary, the next version of base will jump straight to pyrion_base 1358, so we'll get the desired renaming behaviour by default and never need #226

@liamhuber liamhuber closed this Mar 7, 2024
@liamhuber liamhuber deleted the revert_mangle_exploitation branch March 7, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant