Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change username during copy #1728

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Change username during copy #1728

merged 4 commits into from
Jan 15, 2025

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jan 13, 2025 •
edited
Loading

@niklassiemer Can you check if this fixes your issues with copying jobs from other users?

niklassiemer
niklassiemer approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@niklassiemer niklassiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a very small nit in a private method docstring. I tested it and it fixes my issue - thanks a lot 👍

pyiron_base/jobs/job/util.py Outdated Show resolved Hide resolved
@jan-janssen jan-janssen merged commit f748d5a into main Jan 15, 2025
25 checks passed
@jan-janssen jan-janssen deleted the change_username_for_copy branch January 15, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklassiemer niklassiemer niklassiemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-janssen @niklassiemer