-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] Introduce a flag for _not_ mangling the name of wrapped function jobs #1356
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d6f11b1
Introduce a flag for _not_ mangling the name of wrapped function jobs
liamhuber 936e911
Don't even override with function name, just keep the given name
liamhuber fc2572d
Add comment on the private var
liamhuber 77e3ca0
Indent and isolate the entire mangling block
liamhuber c1faf8d
Merge branch 'main' into make_hashing_optional
liamhuber 53a23f9
Update pyiron_base/jobs/flex/pythonfunctioncontainer.py
liamhuber eef7e65
Merge remote-tracking branch 'origin/make_hashing_optional' into make…
liamhuber f69a3d5
Fix early return logic
liamhuber 59f19d6
Use a more descriptive name
liamhuber 171e848
fix formatting
liamhuber 84e3089
Format black
pyiron-runner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel when we have to explain the variable name in a comment, then maybe the variable name is not intuitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was aware of this deficiency -- I fixed it in the stacked PR, but it was still unprofessional of me to just leave it knowingly-bad here.
I find your suggestion loses information on when/why we would rename this, and focuses on the implementation (hashing) instead of the functionality (leveraging input values), so I opted to go with
_automatically_rename_on_save_using_input
.This is definitely an improvement, although in the stacked PR I'm still inclined to leave to comment to give even more depth to why we're doing this.