Merge pull request #1252 from pyiron/datacontainer_cleanup

Simplify the datacontainer clean up during to_hdf()
pyiron · Dec 18, 2023 · 2fdf726 · 2fdf726
2 parents c46434e + 441b66a
commit 2fdf726
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/pyiron_base/storage/datacontainer.py b/pyiron_base/storage/datacontainer.py
@@ -803,12 +803,9 @@ def _to_hdf(self, hdf):
                         "Error saving {} (key {}): DataContainer doesn't support saving elements "
                         'of type "{}" to HDF!'.format(v, k, type(v))
                     ) from None
-        for n in hdf.list_nodes():
+        for n in hdf.list_nodes() + hdf.list_groups():
             if n not in written_keys:
                 del hdf[n]
-        for g in hdf.list_groups():
-            if g not in written_keys:
-                del hdf[g]
 
     def _from_hdf(self, hdf, version=None):
         self.clear()