Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use either pyscal2/3 in calphy job #1622

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Use either pyscal2/3 in calphy job #1622

merged 2 commits into from
Dec 10, 2024

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Dec 10, 2024

MPIE env recently switched from pyscal2 to pyscal3 because calphy dropped the dependency on pyscal2.

@pmrv
Use either pyscal2/3 in calphy job
94b51a9 
MPIE env recently switched from pyscal2 to pyscal3 because calphy dropped
the dependency on pyscal2.
@pmrv pmrv added the bug Something isn't working label Dec 10, 2024
@pmrv pmrv requested a review from srmnitc December 10, 2024 11:10
@coveralls
Copy link

coveralls commented Dec 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12254873270

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 70.904%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/calphy/job.py 0 4 0.0%
Totals Coverage Status
Change from base Build 12245109600: -0.01%
Covered Lines: 10693
Relevant Lines: 15081
💛 - Coveralls

srmnitc
srmnitc approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@srmnitc srmnitc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for updating.

@pmrv pmrv merged commit 7e660db into main Dec 10, 2024
23 of 24 checks passed
@pmrv pmrv deleted the pyscal3 branch December 10, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srmnitc srmnitc srmnitc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmrv @coveralls @srmnitc