Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer error message when no potential tables configured #1537

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Nicer error message when no potential tables configured #1537

merged 3 commits into from
Sep 6, 2024

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Aug 23, 2024

Previously the method raised a ValueError, but #1527 swallowed that by accident.

@coveralls
Copy link

coveralls commented Aug 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10736149650

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 70.934%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/job/potentials.py 3 4 75.0%
Totals Coverage Status
Change from base Build 10735866725: -0.002%
Covered Lines: 10689
Relevant Lines: 15069
💛 - Coveralls

@pmrv pmrv added integration Start the notebook integration tests for this PR format_black reformat the code using the black standard labels Aug 26, 2024
jan-janssen
jan-janssen approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pmrv
Copy link
Contributor Author

pmrv commented Sep 6, 2024

I think the integration test failure is unrelated and maybe a bit unreliable, because #1542 used to have the same failure but in went away after I commited something unrelated.

@jan-janssen jan-janssen merged commit 93c36fc into main Sep 6, 2024
23 of 24 checks passed
@jan-janssen jan-janssen deleted the err branch September 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

Assignees
No one assigned
Labels
format_black reformat the code using the black standard integration Start the notebook integration tests for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmrv @coveralls @jan-janssen