-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pyiron_base to 0.6.14 #1265
Conversation
Waiting for conda-forge/pyiron_base-feedstock#180 |
@pmrv There seems to be an issue with the new read-only objects pyiron/pyiron_base#1162
|
It seems the error originates here where an already run master job has new jobs appended and is re-run. I would actually argue that this is exactly the sort of problem read-only objects are supposed to catch. I could fix this in base, but I really think the test is wrong here in atomistics and should be changed. Thoughts? |
So from what I have reconstructed so far the test actually needs to be written in the original way, because calling run on I've opened a quick fix in base, however as far as I can tell these two classes are the only two serial masters in existence ( |
I would in this case not release a new version. Even if we manage to fix the issue and release before christmas, I will not apply it on the cluster before christmas. |
I would prefer to have a version available that has #1249. I'd say we release the current HEAD (without this PR) and install that on the cluster, that means for now pyiron_base will still be 0.6.13 on the cluster, but I don't see a problem with that. |
No description provided.