Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Graph Indexer WebQSP Refactor and GRetriever Documentation changes #9806

Draft
wants to merge 1,013 commits into
base: master
Choose a base branch
from

Conversation

zaristei
Copy link
Contributor

@zaristei zaristei commented Nov 25, 2024

Successor to 9666, this updates the documentation to show how to utilize GNN RAG and updates WebQSP to help serve as a toy example.
currently blocked by a bug that causes the g_retriever.py example to get 1% less accuracy. may also be the cause of low retrieval precision in #9846

@zaristei zaristei changed the base branch from zaristei/g_retriever_experiments to master November 25, 2024 20:06
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.31%. Comparing base (bd5ae45) to head (25c6ca7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9806      +/-   ##
==========================================
- Coverage   87.07%   86.31%   -0.76%     
==========================================
  Files         490      490              
  Lines       32285    32280       -5     
==========================================
- Hits        28112    27863     -249     
- Misses       4173     4417     +244     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puririshi98
Copy link
Contributor

will merge this once zack joins full time and has bandwidth and compute to debug and ensure that merging his PR keeps test hit metric the same or higher (not lower as is now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants