Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to multinode papers100m default hyperparams and adding eval on all ranks #8823

Merged
merged 61 commits into from
Mar 12, 2024
Merged

Improvements to multinode papers100m default hyperparams and adding eval on all ranks #8823

merged 61 commits into from
Mar 12, 2024

Conversation

puririshi98
Copy link
Contributor

@puririshi98 puririshi98 commented Jan 25, 2024 •
edited
Loading

using main branch of PyG (16 GraceHopper nodes):
Val Acc: 0.4546
Test Acc: 0.3770

using PR branch (2 GraceHopper nodes due to availability):
Validation Accuracy: 51.1759%
Test Accuracy: 44.5692%

PR ready

@puririshi98 puririshi98 requested a review from wsad1 as a code owner January 25, 2024 23:30
@puririshi98 puririshi98 self-assigned this Jan 25, 2024
rusty1s
rusty1s reviewed Mar 6, 2024
View reviewed changes
examples/multi_gpu/papers100m_gcn_multinode.py Outdated Show resolved Hide resolved
examples/multi_gpu/papers100m_gcn_multinode.py Outdated Show resolved Hide resolved
examples/multi_gpu/papers100m_gcn_multinode.py Outdated Show resolved Hide resolved
puririshi98 and others added 14 commits March 6, 2024 16:21
@puririshi98
using acc.compute to align with mag240m and single node papers100m ex…
23179c3 
…amples.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a36248f 
for more information, see https://pre-commit.ci
@puririshi98
Update papers100m_gcn_multinode.py
e0b2301
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b7fe928 
for more information, see https://pre-commit.ci
@puririshi98
cleaning
7c38068
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8eaa4b9 
for more information, see https://pre-commit.ci
@puririshi98
Update papers100m_gcn_multinode.py
55b4f71
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3e1d879 
for more information, see https://pre-commit.ci
@puririshi98
Update papers100m_gcn_multinode.py
a994b62
@puririshi98
Update papers100m_gcn_multinode.py
3a91d03
@puririshi98
Update papers100m_gcn_multinode.py
8ebf762
@puririshi98
Update papers100m_gcn_multinode.py
e10a6ee
@puririshi98
Merge branch 'master' into improve-multinode-example
3b43632
@puririshi98
Merge branch 'master' into improve-multinode-example
ad4497c
@puririshi98
Copy link
Contributor Author

@rusty1s lmk if anything else needed to merge

@rusty1s rusty1s enabled auto-merge (squash) March 12, 2024 14:47
@rusty1s rusty1s merged commit a1251ab into master Mar 12, 2024
12 of 13 checks passed
@rusty1s rusty1s deleted the improve-multinode-example branch March 12, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

@akihironitta akihironitta Awaiting requested review from akihironitta

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

Assignees

@puririshi98 puririshi98

Labels
1 - Priority P1 example feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puririshi98 @rusty1s