Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cache _alpha in GATv2Conv #8753

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Do not cache _alpha in GATv2Conv #8753

merged 1 commit into from
Jan 12, 2024

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Jan 12, 2024

Fixes #8741

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59e9a4e) 89.56% compared to head (ea5310f) 89.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8753      +/-   ##
==========================================
- Coverage   89.56%   89.55%   -0.01%     
==========================================
  Files         482      482              
  Lines       31113    31110       -3     
==========================================
- Hits        27865    27862       -3     
  Misses       3248     3248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit 6e84460 into master Jan 12, 2024
17 checks passed
@rusty1s rusty1s deleted the gatv2_do_not_cache_alpha branch January 12, 2024 12:03
kgajdamo pushed a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GATv2Conv is not inference thread-safe
1 participant