Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-factor Inspector #8750

Merged
merged 28 commits into from
Jan 12, 2024
Merged

Re-factor Inspector #8750

merged 28 commits into from
Jan 12, 2024

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Jan 12, 2024

No description provided.

@rusty1s rusty1s self-assigned this Jan 12, 2024
@github-actions github-actions bot added the nn label Jan 12, 2024
Base automatically changed from module_from_template to master January 12, 2024 08:34
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (6e84460) 89.56% compared to head (13a1fa8) 89.35%.

Files Patch % Lines
torch_geometric/nn/conv/utils/inspector.py 88.31% 18 Missing ⚠️
torch_geometric/nn/conv/propagate.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8750      +/-   ##
==========================================
- Coverage   89.56%   89.35%   -0.21%     
==========================================
  Files         482      482              
  Lines       31112    31203      +91     
==========================================
+ Hits        27864    27882      +18     
- Misses       3248     3321      +73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit c67d07c into master Jan 12, 2024
14 checks passed
@rusty1s rusty1s deleted the module_from_template2 branch January 12, 2024 19:14
kgajdamo pushed a commit that referenced this pull request Jan 22, 2024
@rusty1s @pre-commit-ci @JakubPietrakIntel
Re-factor Inspector (#8750)
403b7b8 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 nn refactor skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rusty1s