Cleanup multinode papers100m get_num_workers
#8368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
approved these changes
Nov 14, 2023
| @@ -19,15 +19,15 @@ | |||
| from torch_geometric.nn import GCNConv | |||
|
|
|||
|
|
|||
| def get_num_workers(world_size: int) -> int: | |||
| def get_num_workers() -> int: | |||
| num_workers = None | |||
| if hasattr(os, "sched_getaffinity"): | |||
There was a problem hiding this comment.
I also wonder, on which platform with pyg and CUDA
os.sched_getaffinityis not available and then you have to fallback toos.cpu_count...
@flxmr os.sched_getaffinity is only available on UNIX systems: https://docs.python.org/3/library/os.html#interface-to-the-scheduler
but since this script is already specialised for a slurm cluster, I think we could also drop it. I'm fine as is though.
rusty1s
approved these changes
Nov 14, 2023
rusty1s
changed the title
get_num_workers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address comments from discussion at end of #8071