Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transforms] Fix sparse-sparse matrix multiplication support on Windows (Part 2) #8225

Merged
merged 3 commits into from
Oct 19, 2023
Merged

[Transforms] Fix sparse-sparse matrix multiplication support on Windows (Part 2) #8225

merged 3 commits into from
Oct 19, 2023

Conversation

EdisonLeeeee
Copy link
Contributor

Address #8219

@EdisonLeeeee EdisonLeeeee self-assigned this Oct 19, 2023
@EdisonLeeeee EdisonLeeeee requested a review from wsad1 as a code owner October 19, 2023 14:33
rusty1s
rusty1s approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, is that a bug in PyTorch?

@rusty1s rusty1s merged commit 5a7d501 into master Oct 19, 2023
5 of 12 checks passed
@rusty1s rusty1s deleted the sparse_mat_windows branch October 19, 2023 14:37
@github-actions github-actions bot added the utils label Oct 19, 2023
@EdisonLeeeee
Copy link
Contributor Author

No exactly. The COO matrix needs to be coalesced after matrix multiplication.

This was referenced Oct 19, 2023
Closed
Merged
rusty1s pushed a commit that referenced this pull request Oct 22, 2023
@EdisonLeeeee
[nit] Remove unnecessary codes in AddRandomWalkPE (#8245)
abf438a 
A follow-up of #8225. We will do `_coalesced_` in `to_edge_index`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

Assignees

@EdisonLeeeee EdisonLeeeee

Labels
0 - Priority P0 bug skip-changelog transform utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdisonLeeeee @rusty1s